Skip to content

fix: store and return engine auth context - #456

Merged
smncd merged 3 commits into
release/sirosidfrom
fix/engine-auth-context
Nov 18, 2026
Merged

smncd merged 3 commits into
release/sirosidfrom
fix/engine-auth-context

Conversation

@smncd

@smncd smncd commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

Frontend part of sirosfoundation/go-wallet-backend#551

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Performance
  • Documentation
  • Tests
  • Build/CI
  • Chore

Related issues / tickets

  • Fixes #
  • Related #

Changes

  • ...

Architecture decisions

  • ...

Screenshots / recordings (if UI changes)

  • ...

How to test

Checklist

  • I self-reviewed my changes
  • I added/updated tests (or explained why not)
  • I updated documentation (if needed)
  • I ran the relevant checks locally (lint/unit/integration)
  • I verified backward compatibility / migration notes (if needed)
  • I added monitoring/logging (if needed)

Security checklist

  • No secrets, credentials, or API keys are hardcoded
  • New dependencies have been reviewed for known vulnerabilities
  • User input is validated and sanitized where applicable
  • No new attack surface introduced without security review
  • PII/sensitive data handling follows data protection policies
  • N/A — this PR does not affect code, deps, or configuration

Notes for reviewers

  • ...

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b2fd6f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wallet-frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smncd
smncd marked this pull request as ready for review November 18, 2026 12:18
@smncd
smncd requested a review from a team as a code owner November 18, 2026 12:18
@smncd
smncd requested review from leifj and s-jairl and a balanced review from Copilot November 18, 2026 12:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing tests bypass authorization-context persistence, leaving redirect/resume behavior across hook remounts, missing-verifier handling, and five-minute expiration without regression coverage.

1 open issue
What changed in this PR

This PR adds frontend support for the signed authorization context introduced in backend PR #551, preserving it across same-tab redirects and forwarding callback issuer information for backend validation.

Changes:

  • Store and return authorization context, with a five-minute pending-flow lifetime.
  • Forward callback state and iss, rejecting duplicate iss parameters.
  • Add callback and transport regression tests and a patch changeset.
File Description
src/​pages/​OpenIDFlowCallback/​OpenIDFlowCallback.tsx Forward iss and reject duplicate parameters.
src/​pages/​OpenIDFlowCallback/​OpenIDFlowCallback.test.tsx Test single, absent, and duplicate iss values.
src/​lib/​openid-flow/​types/​OID4VCITypes.ts Define authorization context and response issuer fields.
src/​lib/​openid-flow/​transports/​OIDFlowWebSocketTransport.ts Map authorization context and send callback validation fields.
src/​lib/​openid-flow/​__tests__/​OIDFlowWebSocketTransport.test.ts Test live and resumed authorization payloads.
src/​hooks/​useOID4VCIFlow.ts Persist and restore context; shorten pending-flow lifetime.
.changeset/​new-lies-film.md Record the patch release change.

Review effort: Balanced

Comment thread src/hooks/useOID4VCIFlow.ts Resolved
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the authorization-context persistence and flow-resumption changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@smncd
smncd merged commit 68a59e5 into release/sirosid Nov 18, 2026
15 checks passed
@smncd
smncd deleted the fix/engine-auth-context branch November 18, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants